accessibility-label rule does not require an accessibilityLabel when accessible={false} #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mattvot Could you merge conflict? |
alex-saunders
suggested changes
Jul 31, 2019
|
@mattvot do you need any help? |
|
I'll try give it a go next week. I've been away for the last few weeks. Thanks. |
|
If someone wants to update the PR or add separately before I can update myself please go ahead 🙂 |
mattvot
force-pushed
the
FixAccessiblePropLabelRule
branch
from
234c41a to
28427bb
Compare
|
Ok, updated now. Let me know if anymore changes are required. Thanks |
|
Any updates on when this will be merged? |
|
Sorry for the delay, thanks for your work on this @mattvot ! Merging now. |
alex-saunders
approved these changes
Oct 17, 2019
|
@alex-saunders Thanks for merging. Any chance of making a new release for this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like #43, do not require an accessibilityLabel when accessible is
false