Add description field to the MergeRequest model #104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m4tthumphrey
added a commit
that referenced
this pull request
Aug 13, 2015
Add description field to the MergeRequest model
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there,
Ran into an issue running Gitlab 7.10 where description was coming back from the API for merge requests, but description was not in the list of properties in Gitlab\Model\MergeRequest. As a result, Gitlab\Model\MergeRequest::fromArray (calling Gitlab\Model\AbstractModel::hydrate) was throwing an exception.
This pull request adds the description key to the list of properties in Gitlab\Model\MergeRequest.
It looks like the current documentation for the Gitlab API lists description as a field, so this shouldn't be a old API version issue, probably will be this way going forward. The list of properties I referenced is available here for review: http://doc.gitlab.com/ee/api/merge_requests.html#get-single-mr
Hope this helps!
Take care,
JB