Add ability to delete an issue comment #150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radutopala
reviewed
Oct 3, 2016
.idea/vcs.xml
Outdated
| @@ -0,0 +1,6 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
Contributor
There was a problem hiding this comment.
@chteuchteu pls remove this file from the commit
quentin-st
force-pushed
the
api/notes/delete
branch
from
e42cf48 to
dc4986e
Compare
Contributor
Author
|
Just rebased my PR to remove the nasty .idea/vcs.xml file that slipped into it |
radutopala
reviewed
Oct 3, 2016
lib/Gitlab/Api/Issues.php
Outdated
| * @param int $note_id | ||
| * @return mixed | ||
| */ | ||
| public function deleteComment($project_id, $issue_id, $note_id) |
Contributor
There was a problem hiding this comment.
@chteuchteu Pls rename to removeComment, to have consistency compared with other methods within the project. See #149 discussion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now, we can only add and update comments.
This PR adds the ability to delete a comment.