Skip to content

Issues API: Add support for 'scope' parameter #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 15, 2017
Merged

Issues API: Add support for 'scope' parameter #247

merged 1 commit into from
Sep 15, 2017

Conversation

@jwillp
Copy link
Contributor

@jwillp jwillp commented Sep 14, 2017

Adds support for the 'scope' parameter introduced in GitLab 9.5 See Issue API

fbourigault
fbourigault suggested changes Sep 14, 2017
View reviewed changes
Copy link
Contributor

@fbourigault fbourigault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing. I would be happy to merge but could you keep the parameters order as in the GitLab documentation and update the method docblock?

fbourigault
fbourigault approved these changes Sep 15, 2017
View reviewed changes
Copy link
Contributor

@fbourigault fbourigault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@fbourigault fbourigault merged commit c0e81e6 into GitLabPHP:master Sep 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@fbourigault fbourigault fbourigault approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jwillp @fbourigault