Skip to content

Add ext-xml as a dependency #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 3, 2017
Merged

Add ext-xml as a dependency #261

merged 1 commit into from
Oct 3, 2017

Conversation

@gmta
Copy link
Contributor

@gmta gmta commented Oct 3, 2017

Without ext-xml a fatal error can occur because of the absence of utf8_encode().

Fixes #260

@gmta
Add ext-xml as a dependency
42b4d46 
Without ext-xml a fatal error can occur because of the absence of utf8_encode().

Fixes #260
@m1guelpf m1guelpf requested a review from fbourigault October 3, 2017 16:08
@fbourigault
Copy link
Contributor

fbourigault commented Oct 3, 2017

Thank you!

@fbourigault fbourigault merged commit 395f25d into GitLabPHP:master Oct 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@m1guelpf m1guelpf m1guelpf approved these changes

@fbourigault fbourigault Awaiting requested review from fbourigault

+1 more reviewer

@20uf 20uf 20uf approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gmta @fbourigault @20uf @m1guelpf