[Jobs] do not encode query parameters at this stage, they are encoded in AbstractApi::preparePath()

[itscaro]

Hello,

I think there is a mistake here.

@lowtower In the commit 91e47d4, you encoded the query parameter at this stage, do you remember what the reason is?

Thank you.

[m1guelpf]

Leaving this open until @lowtower answers

[GrahamCampbell]

Ping @lowtower.

[lowtower]

Sorry,
I do not use this library any more!
I also cannot remember why I requested to encode the $job_name.
Cheers,
LT.

[m1guelpf]

@itscaro Does the early encoding prevent the endpoint from working correctly?

[itscaro]

Hello, I've just done some quick test. I could not get this endpoint work with curl, I tried 3 variants: " ", "%20" and "%2520" (the job name contains a space). The endpoint with job id works for me (https://docs.gitlab.com/ee/api/jobs.html#get-job-artifacts).

I'm no longer using this method of the library so it might take some time if you want me to do further test with the library.

Thanks.

[glensc]

for reference, this PR added the change:

• encode $job_name #318

[GrahamCampbell]

Closing due to lack of evidence and tests. If someone can show the current version is broken and this fixes it, please open a new PR. Otherwise, if I merge this, I risk breaking people's apps.