[19.9] Add missing test annotations #568
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Please could you send this to 19.9. :) |
GrahamCampbell
changed the title
GrahamCampbell
requested changes
Aug 17, 2020
These tests weren't being run! Also fixed failing test due to incorrect method name being called.
Contributor
Author
Rebased on 9.19, hope that's correct :) |
GrahamCampbell
changed the title
Member
|
Yep, this looks great. 👍 |
Contributor
|
I find it more convenient to use matching pattern for method names: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests weren't being run!