[11.5] Fix release creation/update API paths #654
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This issue has been automatically marked as stale because there has been no recent activity. It will be closed after 30 days if no further activity occurs. Thank you for your contributions. |
GrahamCampbell
changed the title
|
@icedream Are you able to finish off this PR please? |
|
I have rebased the branch and fixed up the tests. I am going to skip reorganizing the methods into a separate Releases class since it's a breaking change and I honestly don't have time to work on that anyways atm. This PR is fine for fixing the functionality in the current 11.5 release. |
|
Excellent, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
createReleaseandupdateReleasemethods were implemented in #365 as part of the Tags API, however the API paths have since changed and were not updated. This PR fixes the methods up.Reorganizing the methods into a separate Releases class may be a good idea for a separate PR (breaking change!), as well as implementing other API endpoints. This is not the scope of this PR though.
The Releases API is documented at https://docs.gitlab.com/ee/api/releases/.