Skip to content

[11.8] Add resource events API endpoints #674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Feb 12, 2022
Merged

[11.8] Add resource events API endpoints #674

merged 17 commits into from
Feb 12, 2022

Conversation

@joshuachp
Copy link
Contributor

@joshuachp joshuachp commented Nov 12, 2021

Hi, like #666 that implements the Resource event API, but I needed all 3 types of events.

GrahamCampbell
GrahamCampbell requested changes Dec 26, 2021
View reviewed changes
Copy link
Member

@GrahamCampbell GrahamCampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I've left some inline changes.

@GrahamCampbell GrahamCampbell changed the title Feature: add Resource Events api endpoints [11.6] Add resource events API endpoints Dec 26, 2021
@GrahamCampbell GrahamCampbell changed the base branch from 11.4 to 11.5 December 26, 2021 16:02
@GrahamCampbell GrahamCampbell changed the base branch from 11.5 to 11.6 December 26, 2021 23:32
@joshuachp
Copy link
Contributor Author

joshuachp commented Dec 27, 2021

Reverted changes in d18e1d1

GrahamCampbell
GrahamCampbell requested changes Dec 27, 2021
View reviewed changes
@GrahamCampbell GrahamCampbell changed the title [11.6] Add resource events API endpoints [11.7] Add resource events API endpoints Jan 23, 2022
@GrahamCampbell GrahamCampbell changed the base branch from 11.6 to 11.8 January 24, 2022 03:30
@GrahamCampbell GrahamCampbell changed the title [11.7] Add resource events API endpoints [11.8] Add resource events API endpoints Jan 24, 2022
@GrahamCampbell
Copy link
Member

GrahamCampbell commented Feb 12, 2022

Excellent. Thanks for working on this! 🎉

@GrahamCampbell GrahamCampbell merged commit 238fcc3 into GitLabPHP:11.8 Feb 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GrahamCampbell GrahamCampbell GrahamCampbell approved these changes

Assignees

No one assigned

Labels

changes-required enhancement

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@joshuachp @GrahamCampbell