Skip to content

[11.8] Add reviewer_id and wip fields to "merge_request -> all" route #683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 24, 2022
Merged

[11.8] Add reviewer_id and wip fields to "merge_request -> all" route #683

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1bc5064
Add reviewer_id and wip fields to merge_request -> all route
jkniest Dec 30, 2021
4d4dd7c
Make "wip" a boolean field and add normalizer to convert it into "yes…
jkniest Jan 24, 2022
fbe5554
Fix code style issues
jkniest Jan 24, 2022
f7a94c3
Fixed typo
GrahamCampbell Jan 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/Api/MergeRequests.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,8 @@ class MergeRequests extends AbstractApi
* @var string $labels return merge requests matching a comma separated list of labels
* @var \DateTimeInterface $created_after return merge requests created after the given time (inclusive)
* @var \DateTimeInterface $created_before return merge requests created before the given time (inclusive)
* @var int $reviewer_id return merge requests which have the user as a reviewer with the given user id
* @var bool $wip return only draft merge requests (true) or only non-draft merge requests (false)
* }
*
* @throws UndefinedOptionsException if an option name is undefined
Expand Down Expand Up @@ -136,6 +138,13 @@ public function all($project_id = null, array $parameters = [])
return \count($value) === \count(\array_filter($value, 'is_int'));
})
;
$resolver->setDefined('reviewer_id')
->setAllowedTypes('reviewer_id', 'integer');
$resolver->setDefined('wip')
->setAllowedTypes('wip', 'boolean')
->addNormalizer('wip', static function ($resolver, $wip) {
return $wip ? 'yes' : 'no';
});

$path = null === $project_id ? 'merge_requests' : $this->getProjectPath($project_id, 'merge_requests');

Expand Down