Skip to content

[11.9] Allow update_at order by in Projects::pipelines #710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 6, 2023
Merged

[11.9] Allow update_at order by in Projects::pipelines #710

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1fd05f9
Allow `update_at` order by in `Projects::pipelines`
jdecool May 8, 2022
8c2e92d
Merge branch '11.9' into fix-projects-pipelines-orderby-params
GrahamCampbell Mar 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/Api/Projects.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,9 +337,9 @@ public function enableRunner(int $project_id, int $runner_id)
* @var bool $yaml_errors returns pipelines with invalid configurations
* @var string $name the name of the user who triggered pipelines
* @var string $username the username of the user who triggered pipelines
* @var string $order_by order pipelines by id, status, ref, or user_id (default: id)
* @var string $order_by order pipelines by id, status, ref, updated_at, or user_id (default: id)
* @var string $order sort pipelines in asc or desc order (default: desc)
* @var string $source The source of the pipeline
* @var string $source the source of the pipeline
* }
*
* @return mixed
Expand Down Expand Up @@ -377,7 +377,7 @@ public function pipelines($project_id, array $parameters = [])
->setNormalizer('updated_before', $datetimeNormalizer)
;
$resolver->setDefined('order_by')
->setAllowedValues('order_by', ['id', 'status', 'ref', 'user_id'])
->setAllowedValues('order_by', ['id', 'status', 'ref', 'updated_at', 'user_id'])
;
$resolver->setDefined('sort')
->setAllowedValues('sort', ['asc', 'desc'])
Expand Down