Skip to content

Conversation

@DevMoritz
Copy link
Contributor

added version value for the order_by attribute in GitLab 15.4.
https://gitlab.com/gitlab-org/gitlab/-/merge_requests/95150

Copy link
Member

@GrahamCampbell GrahamCampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Please update the phpdoc and tests, also.

@GrahamCampbell GrahamCampbell changed the title Added tags order_by support for version value [11.10] Added tags order_by support for version value Mar 6, 2023
@GrahamCampbell GrahamCampbell changed the base branch from 11.8 to 11.10 March 6, 2023 22:59
@DevMoritz
Copy link
Contributor Author

@GrahamCampbell the phpdoc was updated. What exactly should I add as a test?

@GrahamCampbell GrahamCampbell merged commit 0c0d270 into GitLabPHP:11.10 Apr 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants