Skip to content

Conversation

@janfejtek
Copy link
Contributor

With this change, it is possible to pass filter to the method https://docs.gitlab.com/ee/api/project_level_variables.html#delete-a-variable.

This should keep it universal in future, but maybe separate filter parameter would be also possible

Copy link
Member

@GrahamCampbell GrahamCampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Please add documentation to what parameters can be passed, in the usual way, and enforce with the options resolver.

@GrahamCampbell GrahamCampbell changed the base branch from 11.10 to 11.12 July 17, 2023 09:33
@GrahamCampbell GrahamCampbell changed the title Passing parameters to removeVariable method [11.12] Passing parameters to removeVariable method Jul 17, 2023
added resolver + docs
add filter level to params
conding style
coding style
@janfejtek
Copy link
Contributor Author

@GrahamCampbell I changed it, so it is under filter key to more follow standard used in other methods. But after that, I could not find any way to use resolver to validate keys on seconds level.

Also the style check fails, but it looks like its issue with formating used in whole file, not only my change and looking at it, it follows project phpdoc fomatting

@GrahamCampbell GrahamCampbell merged commit f8178ae into GitLabPHP:11.12 Oct 8, 2023
@GrahamCampbell
Copy link
Member

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants