Add Secret Manager samples #1010
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethvargo
added
the
kokoro:force-run
googlebot
added
the
cla: yes
Contributor
Author
|
Could someone with permissions please enable the Secret Manager API on the koroko builders: |
kokoro-team
removed
the
kokoro:force-run
Contributor
Author
|
I'm not sure I understand the testing setup? I have a |
dwsupplee
suggested changes
Jan 17, 2020
Contributor
dwsupplee
left a comment
dwsupplee
left a comment
There was a problem hiding this comment.
These are really solid! The samples look very idiomatic in comparison to the rest of the repository and are well documented and clear. Nice work. Most of my comments are very small style/nit related items.
sethvargo
commented
Jan 17, 2020
Contributor
Author
sethvargo
left a comment
sethvargo
left a comment
There was a problem hiding this comment.
Updated @dwsupplee
Contributor
Author
|
Looks like we just need to get koroko happy now |
Contributor
Author
|
And we're greeeeeeeeeeeeeeeeeeeeeeeen! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add initial samples for Secret Manager
/cc @dwsupplee @bshaffer