Use files from php-tools repo. #103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| - php dump_credentials.php | ||
| - travis_retry testing/install_test_deps.sh | ||
| - pushd ${HOME} | ||
| - git clone https://github.com/GoogleCloudPlatform/php-tools.git |
Contributor
There was a problem hiding this comment.
Why are we cloning this instead of just adding it to require-dev in composer.json?
Contributor
Author
There was a problem hiding this comment.
I can do that, but currently we don't have top level composer.json and I just thought it's not warrant to add the top level composer.json. Each test has it in their require-dev.
Contributor
There was a problem hiding this comment.
Ahh, I see. Yeah let's not worry about it then.
Contributor
|
LGTM |
Contributor
Author
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.