Skip to content

feat: add query optimizer version samples #1041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
skuruppu merged 7 commits into from
Mar 17, 2020
Merged

feat: add query optimizer version samples #1041

skuruppu merged 7 commits into from
Mar 17, 2020

Conversation

@larkee
Copy link
Contributor

@larkee larkee commented Mar 12, 2020

No description provided.

@larkee larkee added do not merge Indicates a pull request not ready for merge, due to either quality or timing. api: spanner Issues related to the Spanner API. labels Mar 12, 2020
@larkee larkee requested review from hengfengli and skuruppu March 12, 2020 07:19
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 12, 2020
@larkee larkee requested a review from jsimonweb March 12, 2020 07:20
hengfengli
hengfengli reviewed Mar 12, 2020
View reviewed changes
hengfengli
hengfengli reviewed Mar 12, 2020
View reviewed changes
hengfengli
hengfengli approved these changes Mar 12, 2020
View reviewed changes
Copy link
Contributor

@hengfengli hengfengli left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the CI error. For the rest, LGTM.

@skuruppu skuruppu added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 17, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 17, 2020
@skuruppu skuruppu force-pushed the spanner-query-versioning-samples branch from 8d1b636 to cf01ddb Compare March 17, 2020 04:20
@skuruppu skuruppu removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 17, 2020
@skuruppu skuruppu changed the title spanner: add query versioning samples feat: query optimizer version samples Mar 17, 2020
@skuruppu skuruppu changed the title feat: query optimizer version samples feat: add query optimizer version samples Mar 17, 2020
@skuruppu skuruppu merged commit ca02763 into GoogleCloudPlatform:master Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hengfengli hengfengli hengfengli approved these changes

@skuruppu skuruppu Awaiting requested review from skuruppu

@jsimonweb jsimonweb Awaiting requested review from jsimonweb

Assignees

No one assigned

Labels

api: spanner Issues related to the Spanner API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@larkee @hengfengli @skuruppu @googlebot @kokoro-team