Add an app engine flex memcache sample. #107
Conversation
| ENV DOCUMENT_ROOT /app/web | ||
|
|
||
| # add write permissions to var directory for cache, logs, and session | ||
| RUN mkdir -p /app/var |
There was a problem hiding this comment.
/tmp is always writable. Is it possible to use /tmp instead?
There was a problem hiding this comment.
If it's possible, you can go back to runtime:php
There was a problem hiding this comment.
I copied the Dockerfile that is written when using runtime:php. So I don't know the answer to that question. Who authored the Dockerfile created when deploying runtime:php?
Setting runtime:php failed for me. Let's try that again in a follow up PR.
SurferJeffAtGoogle
force-pushed
the
squashMemFlex2
branch
from
a0a7ebf to
2313411
Compare
|
Ready for another look. |
| * limitations under the License. | ||
| */ | ||
|
|
||
| namespace Google\Cloud\Samples\AppEngine\Symfony; |
There was a problem hiding this comment.
Google\Cloud\Samples\AppEngine\Flexible\Memcache?
SurferJeffAtGoogle
force-pushed
the
squashMemFlex2
branch
from
0da572d to
7881771
Compare
| * limitations under the License. | ||
| */ | ||
| require __DIR__ . '/../vendor/autoload.php'; | ||
| require_once __DIR__ . '/../../../../testing/ExecuteCommandTrait.php'; |
There was a problem hiding this comment.
Nit: ExecuteCommandTrait.php is not needed any more
|
LGTM |
SurferJeffAtGoogle
force-pushed
the
squashMemFlex2
branch
from
7881771 to
a9b9702
Compare
Update DeployTest.php to copy composer.json.
SurferJeffAtGoogle
force-pushed
the
squashMemFlex2
branch
from
a9b9702 to
5fca387
Compare
|
I'll look at mocks in a follow-up PR now. |
|
LGTM once tests pass! |
|
#108 merged, so let's restart the travis job |
4 participants
No description provided.