Skip to content

Conversation

@hannah-tsai
Copy link
Contributor

Fixes b/155346619

Please merge this PR for me once it is approved and [cl/309855045] rolled out to prod.

@hannah-tsai hannah-tsai requested a review from a team as a code owner June 16, 2020 17:30
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 16, 2020
@hannah-tsai hannah-tsai changed the title Update filter field to mutable path docs: Update Security Command Center UpdateNotificationConfig sample, adding filter to mutable field. Jun 16, 2020
Copy link
Contributor

@bshaffer bshaffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you can rebase this with the changes in #1124 I'll merge your addition of the filter.

->setDescription('Updated description.')
->setPubsubTopic($pubsubTopic);
->setPubsubTopic($pubsubTopic)
->setStreamingConfig((new StreamingConfig)->setFilter('state = \"INACTIVE\"'));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used the existing $streamingConfig instantiated above in #1124

@bshaffer bshaffer merged commit 060daf5 into GoogleCloudPlatform:master Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants