Skip to content

fix: dlp samples #1123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bshaffer merged 7 commits into from
Jul 6, 2020
Merged

fix: dlp samples #1123

bshaffer merged 7 commits into from
Jul 6, 2020

Conversation

@bshaffer
Copy link
Contributor

@bshaffer bshaffer commented Jun 26, 2020 •
edited
Loading

  • Refactors out ExponentialBackoffTrait
  • Separates tests
  • Creates a new Pub/Sub topic each test run

@bshaffer bshaffer requested a review from a team as a code owner June 26, 2020 22:45
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 26, 2020
@bshaffer
Copy link
Contributor Author

bshaffer commented Jul 6, 2020

Tests are failing still in REST, but are passing for gRPC. Merging this because it at least fixes some of the tests.

@bshaffer bshaffer merged commit 894b6aa into master Jul 6, 2020
@bshaffer bshaffer deleted the fix-dlp-samples branch July 6, 2020 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bshaffer @googlebot