Add a datastore sample. #116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
appengine/flexible/datastore/app.php
Outdated
| use Symfony\Component\HttpFoundation\Response; | ||
|
|
||
| // Use UTC time. | ||
| date_default_timezone_set('UTC'); |
Contributor
There was a problem hiding this comment.
Rather than set the system-wide default, we should set the timezone on a per-date basis like this:
$date = new DateTime();
$date->setTimezone(new DateTimeZone('UTC'));
//...
['timestampValue' => $date->format('Y-m-d\TH:i:s\Z')]
Contributor
|
Did we look into using tomwalder/php-gds at all for this sample? |
SurferJeffAtGoogle
force-pushed
the
squashDatastore
branch
from
4f928b4 to
cfeca02
Compare
Contributor
Author
|
I didn't look at using using tomwalder/php-gds. I haven't seen us use third-party code like this in samples before. But that library looks good. Should I try using it in a follow-up PR? |
| { | ||
| "require": { | ||
| "silex/silex": "^1.3", | ||
| "google/apiclient": "~2.0@dev" |
Contributor
Contributor
Author
There was a problem hiding this comment.
Dropped.
Contributor
|
LGTM |
SurferJeffAtGoogle
force-pushed
the
squashDatastore
branch
from
cfeca02 to
8b34699
Compare
Contributor
|
@SurferJeffAtGoogle I think it's worth looking into for a follow up PR. If we did use This is definitely LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For https://cloud.google.com/appengine/docs/flexible/php/using-cloud-datastore