Add a cloudsql sample.

[SurferJeffAtGoogle]

For https://cloud.google.com/appengine/docs/flexible/php/using-cloud-sql

[bshaffer]

This would be more consistent with our other samples as:

$pdo = new PDO(
    $app['mysql.dsn'],
    $app['mysql.user'],
    $app['mysql.password']
);

[SurferJeffAtGoogle]

I wish php-cs-fixer did this kind of reformatting automatically.

On Mon, Jun 13, 2016 at 12:18 PM, Brent Shaffer [email protected]
wrote:

In appengine/flexible/cloudsql/app.php
#117 (comment)
:

• * Unless required by applicable law or agreed to in writing, software
• * distributed under the License is distributed on an "AS IS" BASIS,
• * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
• * See the License for the specific language governing permissions and
• * limitations under the License.
• */
  +
  +use Silex\Application;
  +use Symfony\Component\HttpFoundation\Request;
  +use Symfony\Component\HttpFoundation\Response;
  +
  +// create the Silex application
  +$app = new Application();
  +
  +$app['pdo'] = function ($app) {
• $pdo = new PDO($app['mysql.dsn'], $app['mysql.user'],

This would be more consistent with our other samples as:

$pdo = new PDO( $app['mysql.dsn'], $app['mysql.user'], $app['mysql.password']);

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/GoogleCloudPlatform/php-docs-samples/pull/117/files/054148ab7b33853c19dd93176fa20c56378065c4#r66850434,
or mute the thread
https://github.com/notifications/unsubscribe/ALO54oRxFvRNC1cSrhs5ohhYNVbHkDXVks5qLa0BgaJpZM4IzNtf
.

[bshaffer]

Majorly minor nits, otherwise LGTM!