Skip to content

Conversation

@grayside
Copy link
Contributor

This PR adds the first primary Cloud Run sample to the php-docs-samples repo.

  • This is a helloworld sample and will replace the knative-hosted sample at https://cloud.google.com/run/docs/quickstarts/build-and-deploy#php
  • Includes an end-to-end test based on php-tools. It uses ID Token minting support from google/auth, and adds google/auth as a global testing dependency.
  • Proposes a baseline Dockerfile which will be visible in the quickstart: it balances simplicity with Cloud Run runtime optimization by adding opcache and customizing some PHP settings. More advanced topics such as database support or composer builds are left for more specialized samples.
  • Adds a Cloud Run "landing" README along the lines of what Node.js uses.

@grayside grayside requested a review from a team as a code owner September 11, 2020 21:16
@grayside grayside self-assigned this Sep 11, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 11, 2020
@product-auto-label product-auto-label bot added api: run Issues related to the Cloud Run API. samples Issues that are directly related to samples. labels Sep 12, 2020
@@ -0,0 +1,8 @@
<?php

// [START run_helloworld_service]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need to include <?php?

Copy link
Contributor Author

@grayside grayside Sep 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PHP tag must contain the comment.

@bshaffer bshaffer merged commit eec5f5c into master Oct 6, 2020
@bshaffer bshaffer deleted the run/helloworld branch October 6, 2020 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: run Issues related to the Cloud Run API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants