Automatically create the topic and subscription. #118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pubsub/src/app.php
Outdated
| $client = $app['google_client']; | ||
| $projectName = sprintf('projects/%s', $app['project_id']); | ||
| $pubsub = new Google_Service_Pubsub($client); | ||
| $topic = new \Google_Service_Pubsub_Topic(); |
Contributor
There was a problem hiding this comment.
The starting backslash is not required here, or on any of the classes below, since there is no namespace declared at the top of this file.
Contributor
|
LGTM |
pubsub/web/js/pubsub.js
Outdated
| self.message = null; | ||
| }).error(function(data, status) { | ||
| self.logger.error('Failed to send the message. Status: ' + status + '.'); | ||
| if (!self.createdTopicAndSubscription) { |
Contributor
There was a problem hiding this comment.
Shouldn't this be hasAttemptedToCreateTopicAndSubscription?
If the first attempt at posting a message fails.
SurferJeffAtGoogle
force-pushed
the
pubsubAutoCreate
branch
from
cbec8c3 to
51d7319
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the first attempt at posting a message fails.
This means one fewer error that the user has to read, figure out, and fix.