Skip to content

Conversation

@grant
Copy link
Contributor

@grant grant commented Oct 22, 2020

Fixes cd path for sample to work properly.

Fixes #1204

@grant grant requested a review from grayside October 22, 2020 18:47
@grant grant requested a review from a team as a code owner October 22, 2020 18:47
@grant grant self-assigned this Oct 22, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 22, 2020
Copy link
Contributor

@grayside grayside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per request from @bshaffer this command assumes a starting working directory of the directory from where you would have run git clone. I have no opinion either way.

@grant
Copy link
Contributor Author

grant commented Oct 22, 2020

Thanks for the background.

IMO we should please state that assumption then. Or state the cd right after the git clone step.

If a user is linked to this README, the instructions will not work. Usually READMEs are self-isolated and expect you run commands from the directory you're reading the README in.

@bshaffer
Copy link
Contributor

@grant If we include instructions on cloning the repo, we include instructions on changing directory into the repo. This is consistent with all of our tutorials.

If you'd like, split up cd php-docs-samples/run into the previous step where the repo is cloned. This should be clear to everyone.

@grant grant closed this Oct 22, 2020
@grant grant deleted the grant_docs_run_helloworld branch October 22, 2020 19:23
@grant grant reopened this Oct 22, 2020
@grant
Copy link
Contributor Author

grant commented Oct 22, 2020

If you'd like, split up cd php-docs-samples/run into the previous step where the repo is cloned. This should be clear to everyone.

Yeah, that's what I'd suggest.

@bshaffer
Copy link
Contributor

This looks good but you'll need to merge master for it to pass the tests

grant added 2 commits October 22, 2020 15:52
Signed-off-by: Grant Timmerman <[email protected]>
@grant grant force-pushed the grant_docs_run_helloworld branch from 165ec3b to 2832580 Compare October 22, 2020 20:53
@grant
Copy link
Contributor Author

grant commented Oct 22, 2020

Sure. Rebased.

@bshaffer bshaffer merged commit 44689f5 into master Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Run Hello World Sample Instructions Slightly Off

3 participants