Skip to content

Conversation

@jsimonweb
Copy link
Contributor

No description provided.

@jsimonweb jsimonweb requested a review from a team as a code owner October 26, 2020 23:50
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 26, 2020
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Oct 27, 2020
Copy link
Contributor

@bshaffer bshaffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but do we need region tags for both cloud_sql_server_pdo_connection and cloud_sql_sqlserver_pdo_connection?

@jsimonweb
Copy link
Contributor Author

After I've imported the code into docs using cloud_sql_sqlserver_pdo_connection, I'll create another PR to remove the old cloud_sql_server_pdo_connection

@bshaffer bshaffer merged commit de69d57 into GoogleCloudPlatform:master Oct 29, 2020
@jsimonweb jsimonweb deleted the add-sqlserver-regiontags branch October 29, 2020 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants