Skip to content

chore(functions): clean up existing helloworld samples #1210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bshaffer merged 2 commits into from
Nov 2, 2020
Merged

chore(functions): clean up existing helloworld samples #1210

bshaffer merged 2 commits into from
Nov 2, 2020

Conversation

@ace-n
Copy link
Contributor

@ace-n ace-n commented Oct 27, 2020

  • Use dataProvider.
  • Make test variables camelCase.

@ace-n ace-n requested a review from grayside October 27, 2020 02:03
@ace-n ace-n requested a review from a team as a code owner October 27, 2020 02:03
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 27, 2020
@product-auto-label product-auto-label bot added api: cloudfunctions Issues related to the Cloud Run functions API. samples Issues that are directly related to samples. labels Oct 27, 2020
grayside
grayside requested changes Oct 27, 2020
View reviewed changes
@ace-n
Copy link
Contributor Author

ace-n commented Oct 28, 2020 •
edited
Loading

I'm going to hold off on this until #1197 is merged (as there were some semi-accidental changes to these samples there).

@ace-n ace-n added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 28, 2020
@ace-n ace-n force-pushed the helloworld-cleanup branch from c724a42 to 12d68ce Compare October 31, 2020 00:06
@ace-n
Copy link
Contributor Author

ace-n commented Oct 31, 2020 •
edited
Loading

#1197 was merged - I scrapped the old PR in favor of a new branch, though.

(@grayside this one doesn't use url.)

@bshaffer bshaffer merged commit 41135fb into master Nov 2, 2020
@bshaffer bshaffer deleted the helloworld-cleanup branch November 2, 2020 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bshaffer bshaffer bshaffer approved these changes

@grayside grayside grayside approved these changes

Assignees

No one assigned

Labels

api: cloudfunctions Issues related to the Cloud Run functions API. cla: yes This human has signed the Contributor License Agreement. do not merge Indicates a pull request not ready for merge, due to either quality or timing. samples Issues that are directly related to samples.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ace-n @bshaffer @grayside