App Engine Flex Sendgrid sample. #126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| namespace Google\Cloud\Samples\mailgun\test; |
Contributor
There was a problem hiding this comment.
namespace should be sendgrid
SurferJeffAtGoogle
force-pushed
the
squashSendgrid
branch
from
1e7a232 to
060f1a2
Compare
| { | ||
| "require": { | ||
| "silex/silex": "^1.3", | ||
| "symfony/yaml": "^3.1", |
Contributor
There was a problem hiding this comment.
looks like we can move symfony/yaml down to require-dev, since this is only used in the tests.
Contributor
|
One minor tweak, otherwise LGTM |
SurferJeffAtGoogle
force-pushed
the
squashSendgrid
branch
from
060f1a2 to
b260a3c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.