-
Notifications
You must be signed in to change notification settings - Fork 1k
chore(testing): add ability to skip GAE Flex tests #1275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, so we don't actually want to skip all flex tests. We just want to skip flex DEPLOYMENT tests. I think we could do this by:
-
Adding a check in each GAE flex deployment test to verify
RUN_FLEX_DEPLOYMENT_TESTSshould betrue. This could be done by adding this to everyappengine/flexible/*/test/DeployTest.phpfile:/** @beforeClass */ public static function checkFlexDeploymentEnvVar() { self::requireEnv('RUN_FLEX_DEPLOYMENT_TESTS'); }
-
Add a block to
run_test_suite.shto temporarily setRUN_DEPLOYMENT_TESTSto false if the directory contains anapp.yamlwithenv: flex. I can't really see a good/elegant way to do that with the current script though, so I prefer option 1
We already do this - that's what the |
bshaffer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Should we skip the deployment test in endpoints/getting-started as well? I believe so!
Related to b/173545239 and #1242