Skip to content

chore: removed unsupported samples #1303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bshaffer merged 2 commits into from
Mar 12, 2021
Merged

chore: removed unsupported samples #1303

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8d1d7b1
chore: removed unsupported samples
munkhuushmgl Mar 12, 2021
45c6394
chore: removed related tests
munkhuushmgl Mar 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions vision/composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,6 @@
"src/detect_safe_search_gcs.php",
"src/detect_image_property.php",
"src/detect_image_property_gcs.php",
"src/detect_crop_hints.php",
"src/detect_crop_hints_gcs.php",
"src/detect_document_text.php",
"src/detect_document_text_gcs.php",
"src/detect_web.php",
Expand Down
53 changes: 0 additions & 53 deletions vision/src/detect_crop_hints.php
View file
Open in desktop

This file was deleted.

52 changes: 0 additions & 52 deletions vision/src/detect_crop_hints_gcs.php
View file
Open in desktop

This file was deleted.

23 changes: 0 additions & 23 deletions vision/test/visionTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,29 +245,6 @@ public function testImagePropertyCommandGcs()
}

# tests for Vision 1.1 features
public function testCropHintsCommand()
{
$path = __DIR__ . '/data/wakeupcat.jpg';
$output = $this->runCommand('crop-hints', ['path' => $path]);
$this->assertStringContainsString('Crop hints:', $output);
$this->assertStringContainsString('(210,0)', $output);
$this->assertStringContainsString('(476,0)', $output);
$this->assertStringContainsString('(476,475)', $output);
$this->assertStringContainsString('(210,475)', $output);
}

public function testCropHintsCommandGcs()
{
$bucketName = $this->requireEnv('GOOGLE_STORAGE_BUCKET');

$path = 'gs://' . $bucketName . '/vision/wakeupcat.jpg';
$output = $this->runCommand('crop-hints', ['path' => $path]);
$this->assertStringContainsString('Crop hints:', $output);
$this->assertStringContainsString('(210,0)', $output);
$this->assertStringContainsString('(476,0)', $output);
$this->assertStringContainsString('(476,475)', $output);
$this->assertStringContainsString('(210,475)', $output);
}

public function testDocumentTextCommand()
{
Expand Down
23 changes: 0 additions & 23 deletions vision/vision.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,29 +193,6 @@
})
);

// detect crop hints command
$application->add((new Command('crop-hints'))
->setDefinition($inputDefinition)
->setDescription('Detect crop hints in an image using '
. 'Google Cloud Vision API')
->setHelp(<<<EOF
The <info>%command.name%</info> command prints crop hints for an image using
the Google Cloud Vision API.

<info>php %command.full_name% path/to/image.png</info>

EOF
)
->setCode(function ($input, $output) {
$path = $input->getArgument('path');
if (preg_match('/^gs:\/\/([a-z0-9\._\-]+)\/(\S+)$/', $path)) {
detect_crop_hints_gcs($path);
} else {
detect_crop_hints($path);
}
})
);

// detect document text command
$application->add((new Command('document-text'))
->setDefinition($inputDefinition)
Expand Down