Skip to content

Conversation

@bshaffer
Copy link
Contributor

@bshaffer bshaffer commented Jun 8, 2021

No description provided.

@bshaffer bshaffer requested review from ace-n and grayside June 8, 2021 19:23
@bshaffer bshaffer requested a review from a team as a code owner June 8, 2021 19:23
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Jun 8, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jun 8, 2021
@bshaffer bshaffer changed the title feat: add sample for building custom extensions using gcp-build step feat(functions): add sample for building custom extensions using gcp-build step Jun 8, 2021
@ace-n
Copy link
Contributor

ace-n commented Jun 8, 2021

LGTM. I assume you are planning to add these to the docs?

(cc @labtopia - GCF TW)

@product-auto-label product-auto-label bot added the api: cloudfunctions Issues related to the Cloud Run functions API. label Jun 9, 2021
@bshaffer
Copy link
Contributor Author

@ace-n I don't know the best way to add them to the docs. I do have a step-by-step writeup I can turn into a community article or something similar. But I am very open to suggestions. Where is the best place to add these to the docs?

@bshaffer bshaffer changed the title feat(functions): add sample for building custom extensions using gcp-build step feat(functions): add custom extension sample Jun 18, 2021
@bshaffer bshaffer merged commit 7dfed39 into master Aug 17, 2021
@bshaffer bshaffer deleted the functions-concepts_build_step branch August 17, 2021 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: cloudfunctions Issues related to the Cloud Run functions API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants