Adds a datastore sample #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bshaffer
force-pushed
the
add-datastore
branch
from
08e1f4b to
1b6d84e
Compare
Contributor
Author
|
bump |
bshaffer
force-pushed
the
add-datastore
branch
from
1b6d84e to
19ca174
Compare
datastore/README.md
Outdated
Contributor
There was a problem hiding this comment.
I'm confused because Datastore doesn't have push endpoints.
Contributor
Author
There was a problem hiding this comment.
Good call.. I copied the README from pubsub 😨
bshaffer
force-pushed
the
add-datastore
branch
from
19ca174 to
b504558
Compare
datastore/test/datastoreTest.php
Outdated
Contributor
There was a problem hiding this comment.
This is scary, and I haven't needed to do it when writing my tests.
Contributor
Author
There was a problem hiding this comment.
We've discussed this in the pubsub sample... it's there because without it I'd need to create a second file for app.php and include it in the front controller, which I really don't care to do.
bshaffer
force-pushed
the
add-datastore
branch
4 times, most recently
from
803a022 to
12fb6fb
Compare
Contributor
|
Please update the namespaces to match our new policy. |
bshaffer
force-pushed
the
add-datastore
branch
2 times, most recently
from
938e68b to
2f68209
Compare
Contributor
Author
|
@SurferJeffAtGoogle dunzo |
Contributor
|
LGTM. |
bshaffer
force-pushed
the
add-datastore
branch
from
c82c49b to
4e5eda3
Compare
Contributor
Author
|
updated README, which will hopefully be the last thing. PTAL. |
Contributor
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.