[BigQuery] Add Export Command and clean up Doc Blocks #144
Conversation
bshaffer
force-pushed
the
add-bigquery
branch
2 times, most recently
from
7b2e85a to
5b1cc2a
Compare
bshaffer
force-pushed
the
add-bigquery
branch
2 times, most recently
from
c1614a4 to
d77523b
Compare
- fixes docblocks - adds BrowseTableCommand, TablesCommand, and ProjectsCommand - adds test - adds GOOGLE_KEY_FILE for listing projects
| test_table2 | ||
| test_table3 | ||
| ``` | ||
|
|
There was a problem hiding this comment.
Can you provide help text for each subcommand? If so, can we stop having example output in the README since you can put such output in the help text which is little bit better from maintenance standpoint? My only worry is the document will easily become stale.
| { | ||
| if (!$projectId = $input->getOption('project')) { | ||
| if (!$projectId = $this->detectProjectId()) { | ||
| throw new Exception('Could not derive a project ID from gloud. ' . |
|
LGTM |
appengine/standard/http/app.php
Outdated
|
|
||
| # [START guzzle_request] | ||
| $url = 'http://httpbin.org/post?query=update'; | ||
| $url = 'https://httpbin.org/post?query=update'; |
There was a problem hiding this comment.
As I said before, this test depends on external resource which may change anytime. I think we should use something else that we can fully control.
There was a problem hiding this comment.
It can be done in another PR.
(also it's not related to bigquery, so shouldn't it be another PR?)
There was a problem hiding this comment.
I respectfully disagree, and I do not see how this is relevant. I updated this to test HTTPS for a separate issue, it has nothing to do with a problem using an external resource.
There was a problem hiding this comment.
It's not relevant, but we should not rely on external site in general
3 participants
No description provided.