Skip to content

Conversation

@irataxy
Copy link
Contributor

@irataxy irataxy commented Dec 14, 2021

b:197546828

@irataxy irataxy requested a review from a team as a code owner December 14, 2021 21:13
@snippet-bot
Copy link

snippet-bot bot commented Dec 14, 2021

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Dec 14, 2021
Copy link
Contributor

@bshaffer bshaffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The linter needs you to fix the following things:

-    $startTimeInput1Sec = (int)floor(abs($startTimeInput1));
-    $startTimeInput1Nanos = (int)(1000000000 * bcsub(abs($startTimeInput1), floor(abs($startTimeInput1)), 4));
-    $endTimeInput1Sec = (int)floor(abs($endTimeInput1));
-    $endTimeInput1Nanos = (int)(1000000000 * bcsub(abs($endTimeInput1), floor(abs($endTimeInput1)), 4));
+    $startTimeInput1Sec = (int) floor(abs($startTimeInput1));
+    $startTimeInput1Nanos = (int) (1000000000 * bcsub(abs($startTimeInput1), floor(abs($startTimeInput1)), 4));
+    $endTimeInput1Sec = (int) floor(abs($endTimeInput1));
+    $endTimeInput1Nanos = (int) (1000000000 * bcsub(abs($endTimeInput1), floor(abs($endTimeInput1)), 4));

-    $startTimeInput2Sec = (int)floor(abs($startTimeInput2));
-    $startTimeInput2Nanos = (int)(1000000000 * bcsub(abs($startTimeInput2), floor(abs($startTimeInput2)), 4));
-    $endTimeInput2Sec = (int)floor(abs($endTimeInput2));
-    $endTimeInput2Nanos = (int)(1000000000 * bcsub(abs($endTimeInput2), floor(abs($endTimeInput2)), 4));
+    $startTimeInput2Sec = (int) floor(abs($startTimeInput2));
+    $startTimeInput2Nanos = (int) (1000000000 * bcsub(abs($startTimeInput2), floor(abs($startTimeInput2)), 4));
+    $endTimeInput2Sec = (int) floor(abs($endTimeInput2));
+    $endTimeInput2Nanos = (int) (1000000000 * bcsub(abs($endTimeInput2), floor(abs($endTimeInput2)), 4));

@irataxy irataxy requested a review from bshaffer December 22, 2021 18:05
@bshaffer bshaffer merged commit 3beaa75 into GoogleCloudPlatform:master Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants