Skip to content

chore: fix typos, use doublequotes in shell scripts #1588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bshaffer merged 4 commits into from
Apr 9, 2022
Merged

chore: fix typos, use doublequotes in shell scripts #1588

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2a7feb7
fix:Spelling
bluPhy Jan 18, 2022
5046b9d
fix:Adding double quote to prevent globbing and word splitting.
bluPhy Jan 18, 2022
08969c1
Merge branch 'master' into master
bshaffer Mar 7, 2022
1832157
Merge branch 'master' into master
bshaffer Apr 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion logging/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ To use logging sinks, you will also need a Google Cloud Storage Bucket.

You must add Cloud Logging as an owner to the bucket. To do so, add
`[email protected]` as an owner to the bucket. See the
[exportings logs](https://cloud.google.com/logging/docs/export/configure_export#configuring_log_sinks)
[exporting logs](https://cloud.google.com/logging/docs/export/configure_export#configuring_log_sinks)
docs for complete details.

# Running locally
Expand Down
4 changes: 2 additions & 2 deletions testing/run_cs_check.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ PROJECT_ROOT="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )/.."
DIR="${1:-$PROJECT_ROOT}"

# we run the script from PROJECT_ROOT
cd $PROJECT_ROOT
cd "$PROJECT_ROOT"

# install local version of php-cs-fixer 3.0 from composer.json
composer -q install -d testing/
Expand All @@ -30,4 +30,4 @@ if [ -f "testing/vendor/bin/php-cs-fixer" ]; then
PHP_CS_FIXER="testing/vendor/bin/php-cs-fixer"
fi

$PHP_CS_FIXER fix --dry-run --diff --config="${PROJECT_ROOT}/.php-cs-fixer.dist.php" --path-mode=intersection $DIR
$PHP_CS_FIXER fix --dry-run --diff --config="${PROJECT_ROOT}/.php-cs-fixer.dist.php" --path-mode=intersection "$DIR"