feat(compute): Firewall samples refactor #1593
Conversation
rsamborski
added
api: compute
…h parallel run in different PHP versions
rsamborski
added
the
do not merge
| with [additional scopes][additional_scopes]. | ||
|
|
||
| 1. You can create a [Service Account key file][service_account_key_file]. This file can be used to | ||
| authenticate to Google Cloud Platform services from any environment. To use |
There was a problem hiding this comment.
authenticate Google Cloud Platform services ....
There was a problem hiding this comment.
Sorry, but I don't agree with this suggestion. We are authenticating our calls to Google Cloud Platform services/APIs. Removing 'to' means we run the platform services and authenticate them to some other system.
There was a problem hiding this comment.
The context is not clear. Does it mean that the key file is used to 'access' GCP services from any environment?
There was a problem hiding this comment.
Yes. You basically use the key to access GCP services from anywhere (local machine, hosted environment, other cloud, etc.)
There was a problem hiding this comment.
I agree that "to" sounds a big clumsy here, and perhaps it should be "authenticate for" or "authenticate with"
There was a problem hiding this comment.
I have chatted with Alberto (TW in Compute) - he did a quick search in Code Search, and "to" is much more prevalent than "for":
Plus I also found this as an example of to - GitHub Docs.
There was a problem hiding this comment.
Found one more twist here: https://developers.google.com/style/word-list#authentication-and-authorization
The doc suggests using authenticate against, which seems to work too in this case.
rsamborski
removed
the
do not merge
…other tests that depend on the object are finished
…forcer which is sometimes very quick with rule removal
3 participants
Moving firewall samples to a different folder to align with folder structure agreed for future compute samples development.