feat(spanner): Added Samples for Postgres Dialect

[saranshdhingra]

No description provided.

[snippet-bot]

Here is the summary of changes.

You are about to add 16 region tags.

• spanner/src/pg_add_column.php:26, tag spanner_postgresql_add_column
• spanner/src/pg_batch_dml.php:26, tag spanner_postgresql_batch_dml
• spanner/src/pg_case_sensitivity.php:26, tag spanner_postgresql_case_sensitivity
• spanner/src/pg_cast_data_type.php:26, tag spanner_postgresql_cast_data_type
• spanner/src/pg_connect_to_db.php:26, tag spanner_postgresql_create_clients
• spanner/src/pg_create_database.php:26, tag spanner_create_postgres_database
• spanner/src/pg_create_storing_index.php:26, tag spanner_postgresql_create_storing_index
• spanner/src/pg_dml_getting_started_update.php:26, tag spanner_postgresql_dml_getting_started_update
• spanner/src/pg_dml_with_params.php:26, tag spanner_postgresql_dml_with_parameters
• spanner/src/pg_functions.php:26, tag spanner_postgresql_functions
• spanner/src/pg_information_schema.php:26, tag spanner_postgresql_information_schema
• spanner/src/pg_interleaved_table.php:26, tag spanner_postgresql_interleaved_table
• spanner/src/pg_numeric_data_type.php:26, tag spanner_postgresql_numeric_data_type
• spanner/src/pg_order_nulls.php:26, tag spanner_postgresql_order_nulls
• spanner/src/pg_partitioned_dml.php:26, tag spanner_postgresql_partitioned_dml
• spanner/src/pg_query_parameter.php:26, tag spanner_postgresql_query_parameter

---

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

• Refresh this comment

[saranshdhingra]

This should be merged after googleapis/google-cloud-php#5165 is merged and released.

[bshaffer]

These look great but, shouldn't the files and functions be without "spanner", since we are already in the spanner namespace it is a bit redundant, and it will also be more consistent with the region tags (e.g. pg_spanner_add_column => pg_add_column)

[saranshdhingra]

These look great but, shouldn't the files and functions be without "spanner", since we are already in the spanner namespace it is a bit redundant, and it will also be more consistent with the region tags (e.g. pg_spanner_add_column => pg_add_column)

Hey @bshaffer
Thanks for the catch.

I actually followed the go PR for the sample names. But I see the point as these things should make sense for our repo too.

Do you want me to remove the spanner from the file names or make it the same as the region tags like spanner_postgresql_add_column?

[bshaffer]

@saranshdhingra I'd be happy with just removing spanner from the filename and function name. This will be most like our other samples also!

[bshaffer]

Minor nits, otherwise LGTM