Skip to content

Conversation

@jsimonweb
Copy link
Contributor

  • Update region tags
  • Update DB_HOST env. variable to be INSTANCE_HOST
  • Add INSTANCE_UNIX_SOCKET env. variable

@jsimonweb jsimonweb requested a review from a team as a code owner May 12, 2022 22:58
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label May 12, 2022
@snippet-bot
Copy link

snippet-bot bot commented May 12, 2022

Here is the summary of possible violations 😱

Details

There is a possible violation for removing region tag in use.

The end of the violation section. All the stuff below is FYI purposes only.


You are about to delete the following sample browser pages.

You are about to delete the following frozen region tags.

Here is the summary of changes.

You are about to add 3 region tags.
You are about to delete 3 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@jsimonweb jsimonweb requested review from bshaffer and enocom May 12, 2022 23:03

if (empty($username = getenv('DB_USER'))) {
throw new RuntimeException('Must supply $DB_USER environment variables');
if (getenv('DB_USER') !== true) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These values will never equal true... they're either false or a string

https://www.php.net/manual/en/function.getenv.php

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The !== means exactly true, so this condition will always be pass. It should be:

if (getenv('DB_USER') === false) {

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

@jsimonweb jsimonweb requested a review from bshaffer May 23, 2022 20:45
@enocom enocom requested review from dwsupplee and grayside and removed request for grayside May 25, 2022 17:22
@bshaffer bshaffer merged commit de7a67b into GoogleCloudPlatform:master Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants