-
Notifications
You must be signed in to change notification settings - Fork 1k
feat(cloud_sql/mysql): update to V2 sample #1635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cloud_sql/mysql): update to V2 sample #1635
Conversation
jsimonweb
commented
May 12, 2022
- Update region tags
- Update DB_HOST env. variable to be INSTANCE_HOST
- Add INSTANCE_UNIX_SOCKET env. variable
|
Here is the summary of possible violations 😱 DetailsThere is a possible violation for removing region tag in use.
The end of the violation section. All the stuff below is FYI purposes only. You are about to delete the following sample browser pages.
You are about to delete the following frozen region tags.Here is the summary of changes. You are about to add 3 region tags.
You are about to delete 3 region tags.
This comment is generated by snippet-bot.
|
cloud_sql/mysql/pdo/src/app.php
Outdated
|
|
||
| if (empty($username = getenv('DB_USER'))) { | ||
| throw new RuntimeException('Must supply $DB_USER environment variables'); | ||
| if (getenv('DB_USER') !== true) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These values will never equal true... they're either false or a string
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The !== means exactly true, so this condition will always be pass. It should be:
if (getenv('DB_USER') === false) {There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated.