-
Notifications
You must be signed in to change notification settings - Fork 1k
feat(cloud_sql/sqlserver): update to V2 sample #1636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cloud_sql/sqlserver): update to V2 sample #1636
Conversation
|
Here is the summary of possible violations 😱 DetailsThere is a possible violation for removing region tag in use.
The end of the violation section. All the stuff below is FYI purposes only. You are about to delete the following sample browser pages.
You are about to delete the following frozen region tag.Here is the summary of changes. You are about to add 2 region tags.
You are about to delete 2 region tags.
This comment is generated by snippet-bot.
|
| putenv('INSTANCE_HOST'); | ||
| putenv('DB_PASS'); | ||
| putenv('DB_NAME'); | ||
| putenv('DB_USER'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than do this, we can use the /** @runInSeparrateProcess */ annotation in PHPUnit, which ensures that the environment variables are isolated to the call.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Uh oh!
There was an error while loading. Please reload this page.