Skip to content

fix: change Firestore document name to match public docs #1656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bshaffer merged 2 commits into from
Jul 29, 2022
Merged

fix: change Firestore document name to match public docs #1656

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5b75b1f
Fix: change Firestore document name to match public docs
yuhuayang-google Jul 11, 2022
402c811
Merge branch 'master' into fix_firestore_doc_name
bshaffer Jul 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion firestore/src/data_reference_document.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ function data_reference_document(string $projectId): void
]);
# [START fs_document_ref]
# [START firestore_data_reference_document]
$document = $db->collection('samples/php/users')->document('lovelace');
$document = $db->collection('samples/php/users')->document('alovelace');
# [END firestore_data_reference_document]
# [END fs_document_ref]
printf('Retrieved document: %s' . PHP_EOL, $document->name());
Expand Down
2 changes: 1 addition & 1 deletion firestore/src/data_reference_document_path.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ function data_reference_document_path(string $projectId): void
]);
# [START fs_document_path_ref]
# [START firestore_data_reference_document_path]
$document = $db->document('users/lovelace');
$document = $db->document('users/alovelace');
# [END firestore_data_reference_document_path]
# [END fs_document_path_ref]
printf('Retrieved document from path: %s' . PHP_EOL, $document->name());
Expand Down
2 changes: 1 addition & 1 deletion firestore/src/setup_dataset.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ function setup_dataset(string $projectId): void
]);
# [START fs_add_data_1]
# [START firestore_setup_dataset_pt1]
$docRef = $db->collection('samples/php/users')->document('lovelace');
$docRef = $db->collection('samples/php/users')->document('alovelace');
$docRef->set([
'first' => 'Ada',
'last' => 'Lovelace',
Expand Down