-
Notifications
You must be signed in to change notification settings - Fork 1k
feat: add new samples for bigquery #1657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add new samples for bigquery #1657
Conversation
|
Here is the summary of changes. You are about to add 2 region tags.
This comment is generated by snippet-bot.
|
|
Let me know reviewers if I should fix the lint failures as well.. they seem unrelated to my changes. |
|
@vishwarajanand unfortunately we need to fix the lint issues before we merge this PR, so if you're able to look into them that'd be great. The same is true for the PHP 7.3 failures. Edit: I've fixed the CS issues here: #1658 |
bshaffer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor changes only. Otherwise, I can approve this once the tests are passing
Adding samples which are missing on these pages:
bigquery_query_dry_run-> https://cloud.google.com/bigquery/docs/dry-run-queriesbigquery_query_no_cache-> https://cloud.google.com/bigquery/docs/cached-resultsTests: