Skip to content

Conversation

@vishwarajanand
Copy link
Contributor

@vishwarajanand vishwarajanand commented Jul 12, 2022

Adding samples which are missing on these pages:

bigquery_query_dry_run -> https://cloud.google.com/bigquery/docs/dry-run-queries
bigquery_query_no_cache -> https://cloud.google.com/bigquery/docs/cached-results

Tests:

Passes in my local

➜  api git:(bigquery_samples) XDEBUG_MODE=coverage ../../testing/vendor/bin/phpunit --verbose -c phpunit.xml.dist test/*
PHPUnit 8.5.27 #StandWithUkraine

Runtime:       PHP 7.3.33 with Xdebug 3.1.5
Configuration: /usr/local/google/home/vishwarajanand/github/php-docs-samples/bigquery/api/phpunit.xml.dist
Error:         This version of PHPUnit does not support code coverage on PHP 8

.......................                                           23 / 23 (100%)

Time: 1.73 minutes, Memory: 58.00 MB

OK (23 tests, 64 assertions)
➜  api git:(bigquery_samples) 

@vishwarajanand vishwarajanand requested a review from a team as a code owner July 12, 2022 12:32
@snippet-bot
Copy link

snippet-bot bot commented Jul 12, 2022

Here is the summary of changes.

You are about to add 2 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Jul 12, 2022
@vishwarajanand
Copy link
Contributor Author

Let me know reviewers if I should fix the lint failures as well.. they seem unrelated to my changes.

@vishwarajanand vishwarajanand changed the title Added new samples for bigquery feat: add new samples for bigquery Jul 14, 2022
@bshaffer
Copy link
Contributor

bshaffer commented Jul 14, 2022

@vishwarajanand unfortunately we need to fix the lint issues before we merge this PR, so if you're able to look into them that'd be great. The same is true for the PHP 7.3 failures.

Edit: I've fixed the CS issues here: #1658

Copy link
Contributor

@bshaffer bshaffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor changes only. Otherwise, I can approve this once the tests are passing

@bshaffer bshaffer merged commit 54d31c1 into GoogleCloudPlatform:master Jul 15, 2022
vishwarajanand added a commit to vishwarajanand/php-docs-samples that referenced this pull request Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants