Skip to content

Conversation

@meredithslota
Copy link
Contributor

No description provided.

@meredithslota meredithslota requested a review from a team as a code owner November 23, 2022 21:52
@snippet-bot
Copy link

snippet-bot bot commented Nov 23, 2022

Here is the summary of changes.

You are about to add 4 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added api: logging Issues related to the Cloud Logging API. samples Issues that are directly related to samples. labels Nov 23, 2022
Copy link
Contributor

@bshaffer bshaffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this will be followed up by a PR to remove the old prefixes?

@meredithslota
Copy link
Contributor Author

I assume this will be followed up by a PR to remove the old prefixes?

Yes — I'll send a CL to update any sample includes and then follow with a PR to remove the obsolete ones. Thanks for checking!

@meredithslota meredithslota merged commit 4692e92 into main Dec 2, 2022
@meredithslota meredithslota deleted the normalize-region-tags branch December 2, 2022 01:37
@meredithslota
Copy link
Contributor Author

See (draft) PR here: #1736 (will submit for review once CL is submitted).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: logging Issues related to the Cloud Logging API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants