Skip to content

Conversation

@sameer-crest
Copy link
Contributor

Implemented sample for Inspect a string for sensitive data, omitting overlapping matches on domain and email
Added test cases for the same

Reference: https://cloud.google.com/dlp/docs/samples/dlp-inspect-string-without-overlap

@sameer-crest sameer-crest requested a review from bshaffer as a code owner April 10, 2023 06:09
@snippet-bot
Copy link

snippet-bot bot commented Apr 10, 2023

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Apr 10, 2023
Copy link
Contributor

@bshaffer bshaffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer fluid interface calls to always be on separate lines, and I prefer formatting strings over concatenation for readability.

These are not blocking, just suggestions. Nice work!

@sameer-crest
Copy link
Contributor Author

I prefer fluid interface calls to always be on separate lines, and I prefer formatting strings over concatenation for readability.

These are not blocking, just suggestions. Nice work!

Thanks for reviewing the sample code. I have updated the code as per your suggestion.

@bshaffer bshaffer enabled auto-merge (squash) April 19, 2023 14:49
@bshaffer bshaffer merged commit 1dab3cb into GoogleCloudPlatform:main Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants