Skip to content

Conversation

@glasnt
Copy link
Contributor

@glasnt glasnt commented Dec 14, 2023

Because region tags, the <?php occurs after the licence header, which appears verbatim in the source of the deployed service (though to a user only the helloworld message is displayed). Updating the testing assert to 'contains' should allow validation of (essentially) the visible output, without the stricter check.

This change should resolve errors in the deploy_misc test

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Dec 14, 2023
@glasnt glasnt marked this pull request as ready for review December 14, 2023 01:09
@glasnt glasnt requested review from a team as code owners December 14, 2023 01:09
@bshaffer bshaffer merged commit b196013 into main May 31, 2024
@bshaffer bshaffer deleted the run-deploy-tests branch May 31, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants