Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion compute/firewall/composer.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"require": {
"google/cloud-compute": "^1.14"
"google/cloud-compute": "^2.0"
}
}
9 changes: 2 additions & 7 deletions compute/firewall/src/create_firewall_rule.php
Original file line number Diff line number Diff line change
Expand Up @@ -26,13 +26,8 @@
# [START compute_firewall_create]
use Google\Cloud\Compute\V1\Allowed;
use Google\Cloud\Compute\V1\Client\FirewallsClient;
use Google\Cloud\Compute\V1\Enums\Firewall\Direction;

/**
* To correctly handle string enums in Cloud Compute library
* use constants defined in the Enums subfolder.
*/
use Google\Cloud\Compute\V1\Firewall;
use Google\Cloud\Compute\V1\Firewall\Direction;
use Google\Cloud\Compute\V1\InsertFirewallRequest;

/**
Expand All @@ -57,7 +52,7 @@ function create_firewall_rule(string $projectId, string $firewallRuleName, strin
->setPorts(['80', '443']);
$firewallResource = (new Firewall())
->setName($firewallRuleName)
->setDirection(Direction::INGRESS)
->setDirection(Direction::name(Direction::INGRESS))
->setAllowed([$allowedPorts])
->setSourceRanges(['0.0.0.0/0'])
->setTargetTags(['web'])
Expand Down