Skip to content

fixes appengine standard cloudsql test skip statment #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bshaffer merged 1 commit into from
Oct 27, 2016
Merged

fixes appengine standard cloudsql test skip statment #229

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion appengine/standard/cloudsql/test/cloudsqlTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ public function createApplication()
$dsn = getenv('MYSQL_DSN');
$username = getenv('MYSQL_USERNAME');
$password = getenv('MYSQL_PASSWORD');
if (!isset($dsn, $username) || false === $password) {
if (empty($dsn) || empty($username) || false === $password) {
Copy link
Contributor

@tmatsuo tmatsuo Oct 27, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's trivial, but why it only compares $password to false? Can it also be empty($password)?

Copy link
Contributor Author

@bshaffer bshaffer Oct 28, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did this because, while not best practice, it is possible to have an empty password.

$this->markTestSkipped('set the MYSQL_DSN, MYSQL_USER and MYSQL_PASSWORD environment variables');
}

Expand Down