Skip to content

Conversation

@tmatsuo
Copy link
Contributor

@tmatsuo tmatsuo commented Dec 9, 2016

  • google/cloud: ^0.20
  • google/cloud-tools: ^0.6

Copy link
Contributor

@bshaffer bshaffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, I would prefer to have ^0.20, since the convention followed by google/cloud is to break BC on minor releases. This way, we would know for sure that all samples are on the same version. With the current syntax, one sample could be on 0.40 and another on 0.20.

Also, w/o commenting on every single one, I'd like to know why google/auth is added as a dependency.

"paragonie/random_compat": " ^2.0",
"google/cloud-tools": "~0.6"
},
"require": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove the empty require statement here.

"paragonie/random_compat": " ^2.0",
"google/cloud-tools": "~0.6"
},
"require": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove empty require statement here!

"symfony/console": "^3.0"
"google/cloud": "~0.20",
"symfony/console": "^3.0",
"google/auth": "~0.11"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we adding the auth line? This should be left to the google/cloud library unless we are consuming the library directly (which we aren't).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added google/auth because I saw an error like this:

Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - Installation request for google/cloud ^0.20 -> satisfiable by google/cloud[v0.20.0].
    - Conclusion: remove google/auth v0.10
    - google/cloud v0.20.0 requires google/auth ^0.11 -> satisfiable by google/auth[v0.11.0, v0.11.1].
    - Can only install one of: google/auth[v0.11.0, v0.10].
    - Can only install one of: google/auth[v0.11.1, v0.10].
    - Installation request for google/auth (installed at v0.10) -> satisfiable by google/auth[v0.10].

in some sub directories, but you're right

"php": ">=5.4",
"google/cloud": "0.10"
"google/cloud": "~0.20",
"google/auth": "~0.11"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, we can leave this out.

@tmatsuo
Copy link
Contributor Author

tmatsuo commented Dec 9, 2016

@bshaffer PTAL

@tmatsuo
Copy link
Contributor Author

tmatsuo commented Dec 10, 2016

Finally the test passes. @bshaffer PTAL

@bshaffer bshaffer merged commit 4d75c2d into master Dec 12, 2016
@bshaffer bshaffer deleted the version-update branch December 13, 2016 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants