Skip to content

Conversation

@bshaffer
Copy link
Contributor

@bshaffer bshaffer commented Jun 5, 2017

No description provided.

@bshaffer bshaffer requested review from ryanmats and tmatsuo June 5, 2017 23:41
@tmatsuo
Copy link
Contributor

tmatsuo commented Jun 6, 2017

Can you summarize 1) changes and 2) how did you make those changes ? Should I really review all the 98 files?

@bshaffer
Copy link
Contributor Author

bshaffer commented Jun 7, 2017

@tmatsuo thanks! yes, good idea.

  1. Rename every phpunit.xml file to phpunit.xml.dist.
  2. Add Google copyright header to every phpunit.xml.dist.
  3. Indent every phpunit.xml.dist file to 4 spaces
  4. Add <testsuite name="..."> to every phpunit.xml.dist
  5. If test/bootstrap.php was only including vendor/autoload.php, remove test/bootstrap.php and specify vendor/autoload.php as the bootstrap file in phpunit.xml.dist (see Remove unnecessary test/bootstrap.php files #373)

@bshaffer bshaffer merged commit 47430e6 into master Jun 8, 2017
@bshaffer bshaffer deleted the standardize-and-clean-up-tests branch June 8, 2017 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants