Add video samples #403
Merged
Add video samples #403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bshaffer
force-pushed
the
add-video-samples
branch
from
a69e383 to
0d57d8e
Compare
ryanmats
approved these changes
Jul 13, 2017
video/video.php
Outdated
| The <info>%command.name%</info> command finds shot changes in a video using the | ||
| Google Cloud Video Intelligence API. | ||
| $inputDefinition = new InputDefinition([ | ||
| new InputArgument('uri', InputArgument::REQUIRED, 'URI pointing to a video.'), |
Contributor
There was a problem hiding this comment.
Does this have to be a Cloud Storage URI? If so, might be good to specify here.
Contributor
Author
There was a problem hiding this comment.
Yes, currently only Cloud Storage URIs are supported. Good call, I'll add that.
bshaffer
force-pushed
the
add-video-samples
branch
from
0d57d8e to
f1968b6
Compare
bshaffer
commented
Jul 13, 2017
| $results = $operation->getResult()->getAnnotationResults()[0]; | ||
| foreach ($results->getFaceAnnotations() as $face) { | ||
| foreach ($face->getLocations() as $location) { | ||
| if (!$box = $location->getBoundingBox()) { |
Contributor
Author
There was a problem hiding this comment.
This conditional can be removed ~7/17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.