Skip to content

Conversation

@bshaffer
Copy link
Contributor

No description provided.

@bshaffer bshaffer requested a review from ryanmats July 17, 2017 22:21
// Limit the number of findings, 0 for no limit
$maxFindings = 0;

// Whether to include the matching string
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider changing to 'Whether to include the matching string in the response"

$usFemaleNameInfoType->setName('US_FEMALE_NAME');
$infoTypes = [$usMaleNameInfoType, $usFemaleNameInfoType];

// Whether to include the matching string
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider changing to 'Whether to include the matching string in the response"

$usFemaleNameInfoType->setName('US_FEMALE_NAME');
$infoTypes = [$usMaleNameInfoType, $usFemaleNameInfoType];

// Whether to include the matching string
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider changing to 'Whether to include the matching string in the response"

$usFemaleNameInfoType->setName('US_FEMALE_NAME');
$infoTypes = [$usMaleNameInfoType, $usFemaleNameInfoType];

// Whether to include the matching string
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider changing to 'Whether to include the matching string in the response"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in all cases.

@bshaffer bshaffer merged commit 01d6b18 into master Aug 1, 2017
@bshaffer bshaffer deleted the add-dlp-samples branch August 1, 2017 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants