Skip to content

Bump spanner stale read from 10 to 15 seconds. #478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bshaffer merged 1 commit into from
Nov 9, 2017
Merged

Bump spanner stale read from 10 to 15 seconds. #478

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion spanner/src/read_stale_data.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ function read_stale_data($instanceId, $databaseId)
'Albums',
$keySet,
['SingerId', 'AlbumId', 'AlbumTitle'],
['exactStaleness' => new Duration(10)]
['exactStaleness' => new Duration(15)]
);

foreach ($results->rows() as $row) {
Expand Down
6 changes: 3 additions & 3 deletions spanner/test/spannerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,11 +223,11 @@ public function testReadOnlyTransaction()
*/
public function testReadStaleData()
{
// read-stale-data reads data that is exactly 10 seconds old. So, make sure 10 seconds
// read-stale-data reads data that is exactly 15 seconds old. So, make sure 15 seconds
// have elapsed since testUpdateData().
$elapsed = time() - self::$lastUpdateDataTimestamp;
if ($elapsed < 11) {
sleep(11 - $elapsed);
if ($elapsed < 16) {
sleep(16 - $elapsed);
}
$output = $this->runCommand('read-stale-data');
$this->assertContains('SingerId: 1, AlbumId: 1, AlbumTitle: Go, Go, Go', $output);
Expand Down